CFE-4595: Fixed crash when reading empty yaml files#257
Merged
olehermanse merged 1 commit intoNorthernTechHQ:masterfrom Oct 3, 2025
Merged
CFE-4595: Fixed crash when reading empty yaml files#257olehermanse merged 1 commit intoNorthernTechHQ:masterfrom
olehermanse merged 1 commit intoNorthernTechHQ:masterfrom
Conversation
Contributor
Author
|
@cf-bottom jenkins, please :) |
Ticket: CFE-4595 Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12803/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12803/ |
larsewi
approved these changes
Oct 3, 2025
Contributor
Author
|
Debug builds don't crash since they hit an assert, but otherwise I reproduced and fixed the issue. Before: After: |
olehermanse
added a commit
to olehermanse/core
that referenced
this pull request
Oct 3, 2025
Technically, the fix itself is in the libntech repo; NorthernTechHQ/libntech#257 Ticket:CFE-4595 Changelog: Title Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
olehermanse
added a commit
to olehermanse/core
that referenced
this pull request
Oct 3, 2025
Technically, the fix itself is in the libntech repo; NorthernTechHQ/libntech#257 Ticket:CFE-4595 Changelog: Title Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
olehermanse
added a commit
to olehermanse/core
that referenced
this pull request
Oct 3, 2025
Technically, the fix itself is in the libntech repo; NorthernTechHQ/libntech#257 Ticket:CFE-4595 Changelog: Title Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit 2606188)
olehermanse
added a commit
to olehermanse/core
that referenced
this pull request
Oct 3, 2025
Technically, the fix itself is in the libntech repo; NorthernTechHQ/libntech#257 Ticket:CFE-4595 Changelog: Title Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit 2606188)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.