fix: handle page_content_first gallery cover type for linked database views#690
Open
albertodainotti wants to merge 1 commit intoNotionX:masterfrom
Open
fix: handle page_content_first gallery cover type for linked database views#690albertodainotti wants to merge 1 commit intoNotionX:masterfrom
albertodainotti wants to merge 1 commit intoNotionX:masterfrom
Conversation
… views Notion returns gallery_cover type 'page_content_first' (instead of 'page_content') when rendering a linked view of a database. The existing code only matched on 'page_content', causing linked database gallery cards to render with empty covers.
|
@albertodainotti is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Notion page embeds a linked view of a database (as opposed to an inline database), the Notion API returns
gallery_cover.typeas"page_content_first"instead of"page_content".The
CollectionCardcomponent only checked for"page_content", so linked database gallery cards rendered with empty covers even though the image data was correctly fetched and available in therecordMap.Fix
One-line change in
collection-card.tsxto also match on"page_content_first":How to reproduce
After this fix, the covers render correctly.