feat: add benchmark gate for run reports#63
Closed
steezkelly wants to merge 1 commit into
Closed
Conversation
This was referenced May 9, 2026
Author
|
Closing this split PR in favor of consolidated PR #67. Local integration found review/merge overhead across the stack (notably #61/#64 overlap in evolution/skills/evolve_skill.py), and #67 preserves the combined local test evidence: targeted stack tests 21 passed; full suite 160 passed; GitHub checks were absent on the split PRs. Review #67 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #54 step 3: a conservative local
benchmark_gate.pyfor machine-readable evolution run reports.Adds:
evolution/core/benchmark_gate.pyBenchmarkThresholdsandGateResultevaluate_report(report, thresholds)for library usepython -m evolution.core.benchmark_gate --report <report.json>--min-holdout-improvement--max-artifact-growth--max-cost-increase--benchmark-commandBehavior
The gate fails closed when required promotion data is missing or unsafe:
constraints_passedis not trueThe CLI prints deterministic JSON and exits non-zero when the gate fails, matching the issue acceptance criteria.
Scope / non-goals
This PR implements the standalone benchmark gate. It does not yet wire the gate into
evolve_skill.py; that is issue #54 step 5 and should come after run-report generation lands.--benchmark-commandis intentionally local/user-provided. No remote mutation, PR creation, or upstream write occurs.Test Plan
pytest tests/core/test_benchmark_gate.py -qfailed becauseevolution.core.benchmark_gatedid not existpytest tests/core/test_benchmark_gate.py -qpytest -qpython -m evolution.core.benchmark_gate --helpgit diff --checkResult: 146 passed, 11 warnings (DSPy deprecation warnings only).
Partially addresses #54.