This repository was archived by the owner on Nov 26, 2020. It is now read-only.
add 'removeListener' method to have a way to remove the NFC listener#12
Open
clickclickonsal wants to merge 2 commits intoNovadart:developfrom
Open
add 'removeListener' method to have a way to remove the NFC listener#12clickclickonsal wants to merge 2 commits intoNovadart:developfrom
clickclickonsal wants to merge 2 commits intoNovadart:developfrom
Conversation
|
This is not ready yet since you should be able to specify which listeners you want to remove. For example: class Example extends Component {
componentDidMount() {
NFC.addListener(this.logPayload);
}
componentWillUnmount() {
NFC.removeListener(this.logPayload);
}
logPayload(payload) {
console.log(payload);
}
}This way I can specify which listener I can remove :) |
henrikra
reviewed
Aug 7, 2017
| NFC.removeListener = () => { | ||
| DeviceEventEmitter.removeListener(NFC_DISCOVERED); | ||
| _listeners.splice(0, _listeners.length); | ||
| _registeredToEvents = false; |
There was a problem hiding this comment.
What _registeredToEvents variable means in general?
Author
There was a problem hiding this comment.
_registeredToEvents keeps track if the DeviceEventEmitter.addListener is still attached.
This only needs to be set to false if DeviceEventEmitter is removed.
I created a removeAllListeners method because this truly removes the eventListener.
Perhaps I should call removeAllListeners destroy instead?
…AllListeners method
Author
|
The more & more I look at this code, I think it should look something like this instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #8