Add events for tracking rotation and exposing train id changes#9
Open
kirazy wants to merge 3 commits intoNoxyNixie:masterfrom
Open
Add events for tracking rotation and exposing train id changes#9kirazy wants to merge 3 commits intoNoxyNixie:masterfrom
kirazy wants to merge 3 commits intoNoxyNixie:masterfrom
Conversation
Owner
|
Sorry for the late response. I'm not sure I can merge this as it is. There are too many things that bug me about this PR eventhough I'm okay with the goal of the PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four events:
This sets up a generic way for mods to integrate compatibility with this mod, since the primary pain point is tracking train id changes and when rotations occur.
This is part of a related pull request to integrate compatibility with Project Cybersyn.
It's not rigorously tested...