Skip to content

fix: correct min_radial_dist unit mismatch in calc_sfaps #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RaulSimpetru merged 1 commit into from
May 19, 2026
Merged

fix: correct min_radial_dist unit mismatch in calc_sfaps #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions myogen/simulator/core/emg/intramuscular/motor_unit_sim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,9 @@ def calc_sfaps(
electrode_normals : np.ndarray, optional
Electrode normal vectors (not used for point electrodes)
min_radial_dist : float, optional
Minimum radial distance for stability (default: mean diameter * 1000)
Minimum radial distance in mm to prevent singularity when a
fiber is extremely close to the electrode. Defaults to the
mean fiber diameter (in mm).
verbose : bool, default=True
If True, display progress bars. Set to False to disable.
"""
Expand All @@ -265,8 +267,8 @@ def calc_sfaps(

if min_radial_dist is None:
min_radial_dist = float(
np.mean(self.muscle_fiber_diameters__mm) * 1000
) # Convert to micrometers
np.mean(self.muscle_fiber_diameters__mm)
)

if self._neuromuscular_z_coordinates__mm is None:
raise ValueError(
Expand Down
Loading