Closed
Conversation
ItsDoot
reviewed
Aug 19, 2025
james7132
reviewed
Aug 19, 2025
a5a4b20 to
73f85a6
Compare
73f85a6 to
13bc0bb
Compare
Merged
Owner
Author
|
I'm going to merge these changes as part of #40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unifies
ThreadPool::spawn,ThreadPool::spawn_futureandThreadPool::spawn_asyncinto a single genericThreadPool::spawnfunction, and does the same forScope::spawn,Scope::spawn_futureandScope::spawn_async.This brings the api closer to
bevy_tasks(which only supports async spawns) without sacrificing the rayon-style blocking spawns.All of these are now valid: