Skip to content

fix(plugin): fix package versions on Windows and Mac to not suffixes which break version rules on those platforms #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sproctor wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(plugin): fix package versions on Windows and Mac to not suffixes which break version rules on those platforms #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e24fe1d
feat(plugin): add per-OS jpackageVersion for jpackage app-image
sproctor May 29, 2026
2b2b5dd
remove jpackage configuration, just simplify
sproctor May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...in/io/github/kdroidfilter/nucleus/desktop/application/internal/configureJvmApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,8 @@ private fun JvmApplicationContext.configurePackageTask(
packageTask.packageDescription.set(executables.description)
packageTask.packageCopyright.set(executables.copyright)
packageTask.packageVendor.set(executables.vendor)
packageTask.packageVersion.set(packageVersionFor(packageTask.targetFormat))
// jpackage app-image: use the jpackage-safe version.
packageTask.packageVersion.set(jpackageVersionFor(packageTask.targetFormat))
}

val dirSuffix = if (sandboxed) "-sandboxed" else ""
Expand Down
15 changes: 15 additions & 0 deletions ...ain/kotlin/io/github/kdroidfilter/nucleus/desktop/application/internal/packageVersions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,21 @@ internal fun JvmApplicationContext.packageVersionFor(targetFormat: TargetFormat)
?: "1.0.0"
}

/**
* Version used when jpackage builds the app-image (`--app-version`).
*
* jpackage is the only [io.github.kdroidfilter.nucleus.desktop.application.dsl.PackagingBackend.JPACKAGE]
* step ([TargetFormat.RawAppImage]) and enforces strict platform version rules — notably Windows
* rejects SemVer pre-release/build metadata such as `2.3.5-beta.7`. All real installer formats run
* through electron-builder and keep the full SemVer via [packageVersionFor].
*/
internal fun JvmApplicationContext.jpackageVersionFor(targetFormat: TargetFormat): Provider<String> =
packageVersionFor(targetFormat).map { it.toJpackageVersion() }

// jpackage rejects SemVer pre-release/build metadata; keep only the MAJOR.MINOR.PATCH core.
private fun String.toJpackageVersion(): String =
substringBefore('-').substringBefore('+')

@Suppress("CyclomaticComplexMethod") // Exhaustive when on TargetFormat enum
private fun JvmApplicationDistributions.packageVersionFor(targetFormat: TargetFormat): String? {
val formatSpecificVersion: String? =
Expand Down
Loading