Skip to content

fix: pass keepCommentsInBody: true to preserve zmod comment traversal #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johanrd wants to merge 1 commit into from
Closed

fix: pass keepCommentsInBody: true to preserve zmod comment traversal #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,18 @@ import type { Parser, ParseOptions } from "zmod";
*/
export const emberParser: Parser = {
parse(source: string, options?: ParseOptions): any {
const ast = toTree(source, { ...(options as any), includeParentLinks: false });
const ast = toTree(source, {
...(options as any),
includeParentLinks: false,
// zmod walks the tree via visitor keys; keep Glimmer comment nodes
// in GlimmerTemplate.body (with semantic types + longForm) so
// `root.find("GlimmerCommentStatement")` / `root.find("GlimmerMustacheCommentStatement")`
// can reach them. Without this opt-in, ember-estree's default
// removes them from body and surfaces only Block-typed clones
// in `ast.comments` — the right contract for ESLint consumers,
// but invisible to zmod's tree-walker.
keepCommentsInBody: true,
});

return ast;
},
Expand Down