Add AVISO metadata and tests#360
Open
taimoorsohail wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
I thought AVISO was renamed to "satellite altimetry observational dataset by the Copernicus Marine and Environment |
Comment on lines
+122
to
+124
| pad_bounds(bounds, dataset) = begin | ||
| Δ = native_horizontal_resolution(dataset) | ||
| return (bounds[1] - 2Δ, bounds[2] + 2Δ) |
Member
There was a problem hiding this comment.
Suggested change
| pad_bounds(bounds, dataset) = begin | |
| Δ = native_horizontal_resolution(dataset) | |
| return (bounds[1] - 2Δ, bounds[2] + 2Δ) | |
| function pad_bounds(bounds, dataset) | |
| Δ = native_horizontal_resolution(dataset) | |
| return (bounds[1] - 2Δ, bounds[2] + 2Δ) |
Comment on lines
+42
to
+43
| DataWrangling.all_dates(::AVISODaily, variable) = DateTime(1993, 1, 1) : Day(1) : last_complete_day() | ||
| DataWrangling.all_dates(::AVISOMonthly, variable) = DateTime(1993, 1, 1) : Month(1) : last_complete_month() |
Member
There was a problem hiding this comment.
wow, the dataset it is updated every 2 days?
Comment on lines
+45
to
+57
| const AVISO_dataset_variable_names = Dict( | ||
| :free_surface => "adt", | ||
| :ssh => "adt", | ||
| :sea_surface_height => "adt", | ||
| :absolute_dynamic_topography => "adt", | ||
| :adt => "adt", | ||
| :sea_level_anomaly => "sla", | ||
| :sla => "sla", | ||
| :zonal_geostrophic_velocity => "ugos", | ||
| :ugos => "ugos", | ||
| :meridional_geostrophic_velocity => "vgos", | ||
| :vgos => "vgos", | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| const AVISO_dataset_variable_names = Dict( | |
| :free_surface => "adt", | |
| :ssh => "adt", | |
| :sea_surface_height => "adt", | |
| :absolute_dynamic_topography => "adt", | |
| :adt => "adt", | |
| :sea_level_anomaly => "sla", | |
| :sla => "sla", | |
| :zonal_geostrophic_velocity => "ugos", | |
| :ugos => "ugos", | |
| :meridional_geostrophic_velocity => "vgos", | |
| :vgos => "vgos", | |
| ) | |
| const AVISO_dataset_variable_names = Dict( | |
| :free_surface => "adt", | |
| :sea_level_anomaly => "sla", | |
| :zonal_geostrophic_velocity => "ugos", | |
| :meridional_geostrophic_velocity => "vgos", | |
| ) |
| DataWrangling.dataset_variable_name(metadata::Metadata{<:AVISODataset}) = AVISO_dataset_variable_names[metadata.name] | ||
| DataWrangling.dataset_location(::AVISODataset, name) = (Center, Center, Nothing) | ||
| DataWrangling.is_three_dimensional(::Metadata{<:AVISODataset}) = false | ||
| DataWrangling.z_interfaces(::AVISODataset) = (-1.0, 0.0) |
Member
There was a problem hiding this comment.
I think this is not required for 2D datasets (not 100% sure though)
simone-silvestri
approved these changes
Jun 22, 2026
simone-silvestri
left a comment
simone-silvestri
left a comment
Member
There was a problem hiding this comment.
I left some comments. Otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AVISODataWrangling module with monthly and daily surface metadataDataWranglingandNumericalEarthWhy
This wires AVISO into the existing metadata-driven download and
set!workflow so SSH-related fields can be handled the same way as the other supported datasets.Impact
Users can now construct AVISO metadata for fields like
:free_surface,:ssh,:sea_level_anomaly,:ugos, and:vgos, and the test suite has coverage for both downloading and basic field usage.Validation
Meta.parseallAGENTS.md