Add regression test for PrescribedOcean exchange_grid#374
Open
glwagner wants to merge 3 commits into
Open
Conversation
Covers the `exchange_grid(atmosphere, ocean::PrescribedOcean, sea_ice, land)` with-land path fixed in #359. Without the `land=nothing` argument the 4-argument call falls through to the generic method (`ocean.model.grid`) and throws, since `PrescribedOcean` has no `model` field. This test is download-free and runs on both CPU and GPU. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
navidcy
reviewed
Jun 20, 2026
navidcy
approved these changes
Jun 20, 2026
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
simone-silvestri
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #359, which added the
land=nothingargument toexchange_grid(atmosphere, ocean::PrescribedOcean, sea_ice, land)so aPrescribedOceancan be coupled alongside a land component.This adds a focused regression test (
test/test_prescribed_ocean.jl) for thatpath. Without the fix, the 4-argument call falls through to the generic
exchange_gridmethod (ocean.model.grid) and throwsFieldError, sincePrescribedOceanhas nomodelfield — confirmed by running the test againstthe pre-#359 code.
The test is download-free, runs on both CPU and GPU, and completes in ~10s.
It is auto-discovered by
ParallelTestRunner.find_tests, so no change toruntests.jlis needed.🤖 Generated with Claude Code