Use worksize for folded-grid extents#392
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
this seems like something for a kernel launch?
There was a problem hiding this comment.
yeah probably this should be a kernel, I think claude really doesn't like kernels
There was a problem hiding this comment.
This loop is in main, not introduced by this PR, so I think this is an existing bug (not defending Claude of course ;) )
There was a problem hiding this comment.
Have a look now @simone-silvestri @navidcy
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
|
The CI breaks. Was wondering, do we want to change the |
Summary
size(grid)extent calculations withworksize(grid)RightFaceFoldedlaunch semanticsWhy
On
RightFaceFoldedgrids,worksize(grid)includes the extra folded northern row whilesize(grid)does not. These setup paths could therefore build auxiliary fields over1:Nywhile runtime kernels later operate over the folded1:Ny+1working domain, which is a plausible source of seam-local instability.Impact
This keeps extent calculations consistent with folded-grid kernel launches and should reduce the risk of mismatched north-fold state near the seam.
Validation