Fix breeze_over_four_oceans docs example + add missing datasets to table#398
Open
glwagner wants to merge 3 commits into
Open
Fix breeze_over_four_oceans docs example + add missing datasets to table#398glwagner wants to merge 3 commits into
glwagner wants to merge 3 commits into
Conversation
The `breeze_over_four_oceans` example accessed `slab_ocean_atmos.dynamics`, but `atmosphere_simulation` returns a `Simulation`, whose `dynamics` lives on `.model`. The resulting `FieldError` aborted the docs build. Because the example has `build_always=false`, it runs only on the main-push deploy (and labelled PRs), so PR CI never caught it and every main deploy since has failed to publish — freezing the dev docs at a pre-ERA5 build. Also add the CopernicusDEM (`GLO30`, `GLO90`) and GloFAS (`GloFASReanalysis`) datasets to the supported-datasets table, which were shipped but never listed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
glwagner
added
the
build all examples
simone-silvestri
approved these changes
Jul 1, 2026
atmosphere_simulation returns a Simulation, so set!, velocities, microphysical_fields, and liquid_ice_potential_temperature must go through .model, matching breeze_over_slab_land. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XCkJjRLctVm4c7FM7W7Bbx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related docs fixes. The dev docs have been frozen at a pre-ERA5 build for ~a month because every push-to-
maindocs deploy has failed silently.1. Fix the deploy-blocking example
examples/breeze_over_four_oceans.jlaccessedslab_ocean_atmos.dynamics.reference_state, butatmosphere_simulationreturns aSimulation—dynamicslives on.model(AnelasticDynamics, verified to holdreference_state). The bad access threw aFieldErrorthat aborted the whole docs build.Why PR CI never caught it: the example has
build_always=false, so perdocs/make.jl+docs.ymlit is executed only on push-to-main/tags or on PRs labelledbuild all examples. Ordinary PR CI skips it. So PRs stayed green while everymaindeploy died before publishing — freezing dev at the 2026-05-26 build (just before ERA5 was added in #298).2. Add missing datasets to the supported-datasets table
docs/src/Metadata/metadata_overview.mdnever listed some shipped datasets:GLO30,GLO90(CopernicusDEM,:bottom_height) — Bathymetry and static gridsGloFASReanalysis(:river_discharge) — Land(ERA5 was already in the source table since #298; it simply never deployed.)
Verification
This PR carries the
build all exampleslabel so CI runsbreeze_over_four_oceansand confirms the fix on the full deploy path.🤖 Generated with Claude Code