Skip to content

Add tests for sea ice and OceanOnlyModel#411

Open
taimoorsohail wants to merge 4 commits into
mainfrom
ts/test_tracer_closure-with-seaice
Open

Add tests for sea ice and OceanOnlyModel#411
taimoorsohail wants to merge 4 commits into
mainfrom
ts/test_tracer_closure-with-seaice

Conversation

@taimoorsohail

@taimoorsohail taimoorsohail commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Closes #406. This PR extends tracer closure tests to the sea ice and ocean only model.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Diagnostics/interface_fluxes.jl 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@navidcy

navidcy commented Jul 4, 2026

Copy link
Copy Markdown
Member

The test fail when sea_ice is FreezingLimitedOceanTemperature{ClimaSeaIce.SeaIceThermodynamics.LinearLiquidus{Float64}}; we need to add a method for frazil_heat_flux(::EarthSystemModel{<:Any, <:Any, <:Any, <:FreezingLimitedOceanTemperature}.

@navidcy

navidcy commented Jul 4, 2026

Copy link
Copy Markdown
Member

I'm not sure how to estimate the frazil heat that the FreezingLimitedOceanTemperature does. @simone-silvestri, @taimoorsohail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sea-ice in tracer budget closures tests

2 participants