feat: adds support for self in overlay#322
Conversation
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
handrews
left a comment
handrews
left a comment
There was a problem hiding this comment.
This is getting quite close! BTW, I have only had time to review the markdown file, I hope someone else can look at the tests and schemas, and just ping me if there are questions you can't resolve.
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
handrews
left a comment
handrews
left a comment
There was a problem hiding this comment.
GitHub is acting weird- it still shows my "sorry I didn't hit send two days ago" as not having been sent despite it obviously having been.
More importantly, it's showing the entire Markdown file as deleted and re-added?
I'm pretty sure tha changes are correct now based on the discussion, but the diff is unusable and I'm worried something went wrong with a recent commit?
baywet
force-pushed
the
feat/self-support
branch
from
e789604 to
6f3adf7
Compare
It looks like the commit I had made from the UI messed up the line returns somehow. I reapplied that commit correctly and force-pushed. The diff looks ok now. Thanks for calling it out! |
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
|
Are we waiting for anything more here? I had a look at the wording and couldn't see anything I thought needed fixing. You've got approvals from Henry and Ralf, plus a recent but technically outdated approval from @mikekistler but I think we're in good shape here, should I approve and merge? |
|
@lornajane I think we're good on this one, it's been reviewed thoroughly multiple times by different people. The only thing that was missing is your editorial review, and if that's also good, let's merge this! Thanks |
5 participants
fixes #310
heavy use of GCC to put this one together. (based on the discussion in the issue, and the arazzo PR as a template)