[FIX] mail: progress bar if from parameters#1251
Open
HekkiMelody wants to merge 1 commit intoOCA:14.0from
Open
[FIX] mail: progress bar if from parameters#1251HekkiMelody wants to merge 1 commit intoOCA:14.0from
HekkiMelody wants to merge 1 commit intoOCA:14.0from
Conversation
If there was parameters in the from clause, there was a possible error
when reading progress bar for activities.
eg. grouping product.product by "Routes" raise an error because we have
in FORM clause like:
FROM … ON … AND "product_template__route_ids"."route_id" IN
(SELECT … WHERE … OR ("stock_location_route"."company_id" in %s))
so when we add timezone to parameters, it should be after FROM clause
parameters and before WHERE clause parameters.
opw-2674179
closes odoo#78837
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
|
Changes looks fine |
Author
If you think it's fine could you please approve the PR @anusriNPS ? Thank you! |
anusriNPS
approved these changes
Jul 31, 2024
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of commit 904d0aa (Pull request: odoo#78837 ) for 14.0