Skip to content

[18.0][IMP] *: disable auto-install #1301

Merged
pedrobaeza merged 2 commits intoOCA:18.0from
lefilament:18.0-imp-auto_install
Jun 18, 2025
Merged

[18.0][IMP] *: disable auto-install #1301
pedrobaeza merged 2 commits intoOCA:18.0from
lefilament:18.0-imp-auto_install

Conversation

@remi-filament
Copy link
Copy Markdown

Cherry-pick of commits from previous versions : #1242 and #1247

I take over the description from the first PR from @pedrobaeza :

Odoo chooses to auto-install some modules that are debatable, so here in OCB we can revert this decission and let the Odoo admin to decide about them:

  • account_qr_code_sepa: this is just some tooling with no UI, so only modules using this tooling should depend and install it.
  • base_install_request: Feature for asking to install a module that doesn't make too much sense to be auto-installed in on premise maintained installations for avoiding false expectations.
  • iap: Odoo in-app purchases services should be optional, and more having a lot of dependant modules also being auto-installed (sms, snailmail, partner_autocomplete...). This way, we stop the chain from the beginning.
  • l10n_es_edi_facturae: Not everyone in Spain requires Facturae, and even if so, the OCA implementation is more suitable.
  • l10n_es_pos: The implementation of this need is faulty (creating one journal entry per PoS order), so the OCA one should be used instead.
  • mail_bot: It doesn't bring any real feature per se (only the annoying "Write an emoji" initial conversation).
  • pos_epson_printer: Not everyone using PoS has an Epson printer.
  • privacy_lookup: Privacy tool that not everyone uses.
  • sale_pdf_quote_builder: Optional feature.

(I removed sale_product_configurator which has been merged in sale in v18 with odoo#155449)

And 2 more modules from the second PR :

  • google_gmail : all users are not using GMail, it should be installed only when needed
  • web_unsplash : same here, you may not want Odoo to call Unsplash library unwillingly

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

pedrobaeza and others added 2 commits June 18, 2025 11:45
Odoo chooses to auto-install some modules that are debatable, so here in
OCB we can revert this decission and let the Odoo admin to decide about
them:

- account_qr_code_sepa: this is just some tooling with no UI, so only
  modules using this tooling should depend and install it.
- base_install_request: Feature for asking to install a module that
  doesn't make too much sense to be auto-installed in on premise
  maintained installations for avoiding false expectations.
- iap: Odoo in-app purchases services should be optional, and more
  having a lot of dependant modules also being auto-installed (sms,
  snailmail, partner_autocomplete...). This way, we stop the chain from
  the beginning.
- l10n_es_edi_facturae: Not everyone in Spain requires Facturae, and
  even if so, the OCA implementation is more suitable.
- l10n_es_pos: The implementation of this need is faulty (creating
  one journal entry per PoS order), so the OCA one should be used
  instead.
- mail_bot: It doesn't bring any real feature per se (only the annoying
  "Write an emoji" initial conversation).
- pos_epson_printer: Not everyone using PoS has an Epson printer.
- privacy_lookup: Privacy tool that not everyone uses.
- sale_pdf_quote_builder: Optional feature.
@remi-filament
Copy link
Copy Markdown
Author

@pedrobaeza do you mind telling me if the above comments for l10n_es* modules are still accurate ?

@pedrobaeza pedrobaeza added this to the 18 milestone Jun 18, 2025
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, totally! Thanks for rescuing this. It was in my todo list.

@pedrobaeza pedrobaeza requested a review from victoralmau June 18, 2025 10:09
@yotsubasuzu
Copy link
Copy Markdown

Hello guys, small follow-up to mitigate an unexpected consequence of this PR, if you have time, please have a look, thanks: #1308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants