Skip to content

[15.0][FIX] stock: stock_warehouse_orderpoint unlink method domain#1324

Open
PaoloYam wants to merge 2 commits intoOCA:15.0from
PaoloYam:15.0-fix_stock_warehouse_orderpoint_unlink_domain
Open

[15.0][FIX] stock: stock_warehouse_orderpoint unlink method domain#1324
PaoloYam wants to merge 2 commits intoOCA:15.0from
PaoloYam:15.0-fix_stock_warehouse_orderpoint_unlink_domain

Conversation

@PaoloYam
Copy link
Copy Markdown

@PaoloYam PaoloYam commented Jan 8, 2026

Description of the issue/feature this PR addresses:

This PR fixes an incorrect domain construction when restricting records to the current recordset.
The existing code attempted to combine domains using expression.AND() but did not apply the result, and referenced an invalid domain field.

Current behavior before PR:

  • expression.AND() was called without assigning its return value, so the combined domain was never applied.
  • The domain condition used ('ids', 'in', self.ids), which is not a valid searchable field.
  • As a result, the intended filtering by the current recordset was silently ignored.

Desired behavior after PR is merged:

  • The domain is correctly rebuilt and assigned using expression.AND().
  • The filter uses the valid field instead of ids
  • Records are properly restricted to the current recordset

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@PaoloYam
Copy link
Copy Markdown
Author

change validated in 18.0: odoo#242799

@OCA-git-bot
Copy link
Copy Markdown

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants