account : prevent double membership to 'group_show_line_subtotals_tax_excluded' and 'group_show_line_subtotals_tax_included' that is forbidden in V12#3124
Conversation
…_excluded' and 'group_show_line_subtotals_tax_included' that is forbidden in V12
| def fix_double_membership(cr): | ||
| # avoid error raised by new function '_check_one_user_type' | ||
|
|
||
| # we arbitrarily keep the tax included |
There was a problem hiding this comment.
Please keep tax excluded as B2B is the most usual one in my experience.
There was a problem hiding this comment.
My point was : B2B is the default, so if the user has b2c selected, it's intented. Dont't you think ?
There was a problem hiding this comment.
Is that really that way? Shouldn't all the users be homogeneous with one or the other? Applying res.config.settings apply to all users.
There was a problem hiding this comment.
I think Pedro is right. res.config.settings wipes the users from the groups that are deactivated: https://github.com/odoo/odoo/blob/12.0/odoo/addons/base/models/res_config.py#L586-L587
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
4 participants
Same as here : #2999 for account module.
CC : @fcayre, @pedrobaeza, @MiquelRForgeFlow