Merged
Conversation
Contributor
|
/ocabot migration sale_project |
openupgrade_scripts/scripts/sale_project/18.0.1.0/upgrade_analysis_work.txt
Show resolved
Hide resolved
remi-filament
force-pushed
the
18.0-add-sale_project
branch
2 times, most recently
from
5ebe521 to
033bc3f
Compare
remi-filament
force-pushed
the
18.0-add-sale_project
branch
from
033bc3f to
702a3e6
Compare
Contributor
Author
|
Thanks for your review, @MiquelRForgeFlow I did as suggested |
MiquelRForgeFlow
approved these changes
Jul 28, 2025
Comment on lines
+22
to
+23
| AND p.sale_line_id IS NOT NULL | ||
| AND p.sale_line_id = sol.id |
Contributor
There was a problem hiding this comment.
Suggested change
| AND p.sale_line_id IS NOT NULL | |
| AND p.sale_line_id = sol.id | |
| AND p.sale_line_id = sol.id |
Contributor
|
please rebase :) |
pedrobaeza
approved these changes
Jul 30, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
One comment inline, but I can modify it after merging.
|
|
||
| sale_project / product.template / project_id (many2one) : needs conversion to v18-style company dependent | ||
| sale_project / product.template / project_template_id (many2one): needs conversion to v18-style company dependent | ||
| # DONE: pre-migration: copy columns if exist |
Member
There was a problem hiding this comment.
Suggested change
| # DONE: pre-migration: copy columns if exist | |
| # DONE: pre-migration: renames columns if they exist for avoiding collapses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.