Skip to content

[17.0][OU-ADD] l10n_fr: Migration scripts#5533

Merged
OCA-git-bot merged 1 commit into
OCA:17.0from
lefilament:17.0-add-l10n_fr
Mar 16, 2026
Merged

[17.0][OU-ADD] l10n_fr: Migration scripts#5533
OCA-git-bot merged 1 commit into
OCA:17.0from
lefilament:17.0-add-l10n_fr

Conversation

@remi-filament

Copy link
Copy Markdown

Migration scripts for l10n_fr
Nothing to do for other l10n_fr modules.

@remi-filament

Copy link
Copy Markdown
Author

I have a question not directly related to this PR regarding l10n_fr_hr_holidays (new module added in v17 with auto_install if you have both l10n_fr and hr_holidays installed).
There is a new parameter added in res_company and related one in res.config_settings that I would like to initialize. Since this module cannot be installed in v16, how can I make sure that my migration scripts are run during v17 migration ? Where should I define those scripts ?

I am pretty sure you have the answer @hbrunn or @MiquelRForgeFlow ?
Thanks !

@hbrunn

hbrunn commented Feb 23, 2026

Copy link
Copy Markdown
Member

I am pretty sure you have the answer @hbrunn or @MiquelRForgeFlow ? Thanks !

just write a migration script for the new module, for exactly this reason we patch Odoo to also run migration scripts for newly installed modules. If that doesn't work, that's a but in openupgrade_framework

@remi-filament

Copy link
Copy Markdown
Author

Hi @hbrunn thank you for your answer.
I just published a PR with script for l10n_fr_hr_holidays, although script is never run. We should probably continue the conversation in the other PR !
#5539

@remi-filament

Copy link
Copy Markdown
Author

Fixes #5491

@flotho flotho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully tested in a migration
LGTM
Thanks

@hparfr hparfr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @remi-filament

Tested in a CI.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn

hbrunn commented Mar 16, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-5533-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 895aec5 into OCA:17.0 Mar 16, 2026
4 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 895aec5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants