Skip to content

[18.0][FIX] agreement_legal: remove redundant t-name from report_agreement_document#109

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
HeliconiaIO:18.0-fix-agreement_legal
Mar 31, 2026
Merged

[18.0][FIX] agreement_legal: remove redundant t-name from report_agreement_document#109
OCA-git-bot merged 1 commit intoOCA:18.0from
HeliconiaIO:18.0-fix-agreement_legal

Conversation

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor

Issue:
The report_agreement_document template contained a redundant <t t-name="agreement.report_agreement_document"> wrapper inside the <template> tag. In modern Odoo versions, this triggers the following warning in the logs:
Unknown directives or unused attributes: {'t-name'} in agreement_legal.report_agreement_document

Reference :- OCA/sign#118

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @max3903, @ygol,
some modules you are maintaining are being modified, check this out!

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor Author

ping @lbarry-apsl @peluko00

Copy link
Copy Markdown
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and runboat reviewed. LGTM

Copy link
Copy Markdown

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor Author

@pedrobaeza can we merge this?

Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the diff is so big?

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor Author

Why the diff is so big?

The diff is large because of the pre-commit formatting changes. Some lines were reformatted. which increased the overall diff.

@pedrobaeza
Copy link
Copy Markdown
Member

That doesn't seem the problem. You have reduced an indentation level removing <t t-name="agreement.report_agreement_document">. Is that provoking any problem?

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor Author

That doesn't seem the problem. You have reduced an indentation level removing <t t-name="agreement.report_agreement_document">. Is that provoking any problem?

The indentation change is due to removing . After removing that tag, I ran the pre-commit hooks, which only reformatted the file accordingly. No other changes were introduced apart from that.

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor Author

ping @pedrobaeza

@pedrobaeza pedrobaeza added this to the 18.0 milestone Mar 31, 2026
@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-109-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3da3952 into OCA:18.0 Mar 31, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7dad6a7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants