[19.0][MIG] agreement: Migration to 19.0 by Vang-NguyenPhu · Pull Request #99 · OCA/agreement

Vang-NguyenPhu · 2026-01-15T08:03:42Z

No description provided.

we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default)

- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477

Update agreement and agreement_sale to restore the behavior of v10

…ad of onchange field

Co-authored-by: Denis Roussel (ACSONE) <rousseldenis@users.noreply.github.com>

leemannd · 2026-01-15T13:23:26Z

/ocabot migration agreement

leemannd · 2026-01-15T13:27:34Z

Hello @Vang-NguyenPhu , Is it possible to reduce the commit history by following -> https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0
Also I am expecting to have at least two migration commits:

pre-commit
a migration commit

Vang-NguyenPhu · 2026-01-21T07:55:01Z

Hello @Vang-NguyenPhu , Is it possible to reduce the commit history by following -> https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0 Also I am expecting to have at least two migration commits:

pre-commit

a migration commit

I rebased some Bot's commit.
Actually, there is nothing to commit at the first pre-commit

CRogos · 2026-01-21T18:26:27Z

Currently agreement and agreement_legal is a little confusing. Especially the Form, which is in agreement_legal not reused.

Maybe we can change agreement a little bit so that the extensions can more easily link in?

Add a group "Gernal" and "Term Dates" in module agreement
Maybe move some attributes to agreement_legacy when they are hidden by agreement_legal?

In agreement_legal there is already a roadmap what should be changed.

We are not yet using agreement but are interested. Currently there is a lot of stuff we don't need and would like to hide (or better not install).

cc: @MohamedOsman7

CRogos

Could you squash some of the commits?

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

yankinmax · 2026-03-27T08:37:42Z

Hello @OCA/project-service-maintainers can you pls take a look and possibly trigger merge?

Currently translated at 100.0% (64 of 64 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

By shifting the constraint to the commercial entity, computed from the partner field, we can now select hierarchy contacts. This is useful to: A) Register the contact person of the agreement B) Support modules like `partner_affiliate`, in case of nested businesses

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/de/

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/fr/

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

Currently translated at 100.0% (74 of 74 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

Currently translated at 100.0% (74 of 74 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

Currently translated at 100.0% (73 of 73 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

Vang-NguyenPhu · 2026-03-27T09:14:56Z

Could you squash some of the commits?

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

I think it's good now.

hieulucky111

Code review and it looks good!

yankinmax · 2026-03-27T09:26:22Z

Hello @rousseldenis , sorry for pinging you directly, can you pls take a look and possibly trigger merge?

rousseldenis · 2026-03-27T09:31:45Z

/ocabot merge nobump

OCA-git-bot · 2026-03-27T09:31:54Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-99-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2026-03-27T09:35:02Z

Congratulations, your PR was merged at 63e3618. Thanks a lot for contributing to OCA. ❤️

ygol and others added 19 commits January 15, 2026 14:59

[MIG] agreement: Migration to 12.0

13b5bdb

FIX security issue + details

8ae65f3

[FIX] Missing newline

6e9b65a

[IMP] agreement,agreement_legal: support activities

87ed16f

- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477

[IMP] agreement: Minor improvements

3625dad

Re-introduce module agreement_account

054a7d2

Update agreement and agreement_sale to restore the behavior of v10

[IMP] agreement: black, isort, prettier

f6d06e7

[MIG] agreement: Migration to 13.0

f69508e

[IMP] agreement: black, isort, prettier

0d7eb82

[MIG] agreement: Migration to 14.0

d169adc

[IMP] agreement: black, isort, prettier

a8f3af7

[MIG] agreement: Migration to 15.0

239b7bf

[IMP] agreement: Change menus structure to make it easy to adapt

ac6a7c5

[MIG] agreement: Migration to 16.0

5638cdc

[IMP] agreement - Change domain field into computed store field inste…

b2a7e21

…ad of onchange field

[IMP] agreement: pre-commit auto fixes

863dda0

[MIG] agreement: Migration to 17.0

d1c0ac2

Update agreement/models/agreement.py

cbec23f

Co-authored-by: Denis Roussel (ACSONE) <rousseldenis@users.noreply.github.com>

Vang-NguyenPhu force-pushed the 19.0-mig-agreement branch 2 times, most recently from 6540d3e to 6f1b2e5 Compare January 15, 2026 08:43

Vang-NguyenPhu mentioned this pull request Jan 15, 2026

Migration to version 19.0 #90

Open

5 tasks

OCA-git-bot added this to the 19.0 milestone Jan 15, 2026

Vang-NguyenPhu force-pushed the 19.0-mig-agreement branch from 6f1b2e5 to 8f1b55a Compare January 21, 2026 07:52

Vang-NguyenPhu mentioned this pull request Feb 4, 2026

[19.0][MIG] agreement_sale: Migration to 19.0 #100

Open

gdgellatly mentioned this pull request Feb 28, 2026

[19.0][MIG] agreement_rebate: Migration to 19.0 #108

Merged

3 tasks

ivantodorovich approved these changes Mar 17, 2026

View reviewed changes

CRogos reviewed Mar 18, 2026

View reviewed changes

mymage and others added 15 commits March 27, 2026 16:11

Translated using Weblate (Italian)

9cff018

Currently translated at 100.0% (64 of 64 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/

[IMP] agreement: pre-commit execution

d526e6b

[MIG] agreement: Migration to 18.0

c164300

Translated using Weblate (Italian)

213d853

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

Added translation using Weblate (Swedish)

5bb3c35

[IMP] agreement: Update logo

4739140

Translated using Weblate (German)

360a641

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/de/

Translated using Weblate (French)

b62cf6b

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/fr/

Translated using Weblate (Swedish)

cf4ab1f

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

[MOV] agreement_legal > agreement: res.partner.agreement_[ids|count]

505b7d0

Translated using Weblate (Italian)

0868cef

Currently translated at 100.0% (74 of 74 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

Translated using Weblate (Swedish)

d94edf3

Currently translated at 100.0% (74 of 74 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

Translated using Weblate (Italian)

6d57126

Currently translated at 100.0% (73 of 73 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

[MIG] agreement: Migration to 19.0

5f522f7

Vang-NguyenPhu force-pushed the 19.0-mig-agreement branch from 8f1b55a to 5f522f7 Compare March 27, 2026 09:11

hieulucky111 approved these changes Mar 27, 2026

View reviewed changes

rousseldenis approved these changes Mar 27, 2026

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 27, 2026

OCA-git-bot merged commit 4b8c88c into OCA:19.0 Mar 27, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 27, 2026

Uh oh!

Conversation

Vang-NguyenPhu commented Jan 15, 2026

Uh oh!

leemannd commented Jan 15, 2026

Uh oh!

leemannd commented Jan 15, 2026

Uh oh!

Vang-NguyenPhu commented Jan 21, 2026

Uh oh!

CRogos commented Jan 21, 2026

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Mar 27, 2026

Uh oh!

Vang-NguyenPhu commented Mar 27, 2026

Uh oh!

hieulucky111 left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Mar 27, 2026

Uh oh!

rousseldenis commented Mar 27, 2026

Uh oh!

OCA-git-bot commented Mar 27, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants