[16.0][ADD] calendar_shared_ics#199
Draft
ntsirintanis wants to merge 4 commits intoOCA:16.0from
Draft
Conversation
Kiplangatdan
suggested changes
Jan 14, 2026
| </group> | ||
| <group string="Subscription link"> | ||
| <field name="share_webcal_url" readonly="1" widget="copy" /> | ||
| <field name="share_url" readonly="1" widget="copy" /> |
Member
There was a problem hiding this comment.
@ntsirintanis Correct widget should be CopyClipboardChar:
| res = super()._compute_access_url() | ||
| base_url = self.get_base_url() | ||
| for cal in self: | ||
| cal.access_url = f"{base_url}/calendar/shared/{cal.id}/ics" |
Author
There was a problem hiding this comment.
Not really, this is just the url for that given calendar.shared.ics record, but without the access_token. It is just for being displayed
Kiplangatdan
suggested changes
Jan 22, 2026
| else: | ||
| users = self.env["res.users"].search(["|"] + user_domain) | ||
| partner_ids = users.mapped("partner_id").ids | ||
| return {"domain": {"partner_id": [("id", "in", partner_ids)]}} |
Member
There was a problem hiding this comment.
@ntsirintanis Two things here:
-
Returning a domain is deprecated in v16 in favor of using a computed function.
E.g in partner_contact_address_default and usage in the view -
The current domain filter somehow doesn't work well when you include portal users:
ntsirintanis
force-pushed
the
16.0-calendar_shared_ics
branch
from
53d0f01 to
ae43446
Compare
Kiplangatdan
approved these changes
Jan 26, 2026
Member
Kiplangatdan
left a comment
Kiplangatdan
left a comment
There was a problem hiding this comment.
@ntsirintanis Retested, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module allows sharing an Odoo calendar as a read-only ICS feed that can be
subscribed to in external calendar clients such as Outlook, Google Calendar,
and Thunderbird.
The calendar is exposed via a public URL protected by an access token and can be
added as a network calendar (ICS /
webcal://). External calendar clients periodicallyrefresh the feed, providing near-real-time visibility of Odoo events without any
write-back capability.