Skip to content

[19.0][ADD] subscription_oca_rating#1454

Open
alvaro-domatix wants to merge 1 commit into
OCA:19.0from
alvaro-domatix:19.0-add-subscription_oca_rating
Open

[19.0][ADD] subscription_oca_rating#1454
alvaro-domatix wants to merge 1 commit into
OCA:19.0from
alvaro-domatix:19.0-add-subscription_oca_rating

Conversation

@alvaro-domatix

Copy link
Copy Markdown

New bridge module between subscription_oca and the rating addon.

sale.subscription inherits rating.mixin, so the standard rating statistics (last value, average, count, satisfaction percentage) become available on subscriptions. A header button sends a configurable rating request email to the customer, and the same request is sent automatically when the subscription is closed (both the close wizard and the cron go through it); a failure to send never blocks the close. The form gets a stat button to the ratings of the contract and the search view a "With ratings" filter.

Shipped as a separate addon to keep the rating dependency out of the core module.

@OCA-git-bot OCA-git-bot added series:19.0 mod:subscription_oca_rating Module subscription_oca_rating labels Jun 9, 2026
@alvaro-domatix alvaro-domatix force-pushed the 19.0-add-subscription_oca_rating branch from 5ec54b6 to e039e8d Compare June 9, 2026 19:21
New bridge module between `subscription_oca` and the community
`rating` addon. Inheriting `rating.mixin` on `sale.subscription`
exposes the standard rating statistics (last value, average, count,
satisfaction percentage, etc.) on the subscription and lets users
see and search ratings via the standard Rating model.

* `sale.subscription` extension adds `rating.mixin` (with the
  `_inherit` order `['rating.mixin', 'sale.subscription']` to keep
  the MRO consistent).
* `action_send_rating_request` sends a configurable mail template
  to the subscription's partner.
* Form view: header button to send the rating email + stat button
  linking to the standard rating list filtered for this contract.
* Search view: "With ratings" filter.
* Mail template `mail_template_subscription_rating_request` ships as
  loadable data, so it can be customised per instance.

Lives in its own addon directory because `rating` is LGPL-3 and not
acceptable in the core module dependencies (§0.3 of the project
guidelines).
@alvaro-domatix alvaro-domatix force-pushed the 19.0-add-subscription_oca_rating branch from e039e8d to 9bab2ac Compare June 9, 2026 20:04

@jorgeglez1990 jorgeglez1990 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Functional Review

@pablolopez-domatix pablolopez-domatix left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yvaucher

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-1454-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@yvaucher The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_subscription_oca_rating-19.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_subscription_oca_rating-19.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests                                                      

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants