[19.0][IMP] contract: harden the recurring-invoice cron#1459
Open
bosd wants to merge 1 commit into
Open
Conversation
Make the recurring-invoice cron robust with a per-contract failure flag, mute the logger when tests seed an invoice-generation error, and tidy the cron error log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #1427 (per @pedrobaeza's request to break the big PR into focused ones).
Hardens the recurring-invoice cron so one bad contract can no longer block a whole company's batch.
Two-tier execution
account.move.create([...])per company (unchanged behaviour/performance).cr.savepoint(), so a single contract with bad data doesn't poison the transaction for the rest (SQL-level errors included).Per-contract failure trail
invoice_generation_error/invoice_generation_error_date/has_invoice_generation_error.decoration-warningrow tint in the list, and a form banner with a Dismiss button.Tests: isolation of a failing contract, error/activity population, recovery clearing, no duplicate chatter/activity, fast-path retention, and the dismiss/view actions.