[18.0][IMP] subscription_oca: Add automatic recurring payment#1463
Open
chrisandrewmann wants to merge 1 commit into
Open
[18.0][IMP] subscription_oca: Add automatic recurring payment#1463chrisandrewmann wants to merge 1 commit into
chrisandrewmann wants to merge 1 commit into
Conversation
997db94 to
3f7992c
Compare
Author
|
@tarteo @yvaucher @carlos-domatix @rousseldenis Would appreciate your input in testing and hopefully getting merged this time around! I think it's a feature we've all needed for a while. |
5039eb0 to
2e656ed
Compare
2e656ed to
a02fb6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automatic recurring payment to
subscription_oca. When enabled, a subscription charges the customer's saved payment token on each billing run, removing the manual collection step for merchant-initiated recurring payments (stored card, BACS/SEPA direct debit, etc. via a tokenizing payment provider).Purpose
subscription_ocacould only generate invoices; collecting payment was always manual. This closes that gap while guaranteeing a customer is never sent an invoice for money that has not actually been collected.Changes
account_payment.18.0.1.0.0→18.0.2.0.0.Invoicing mode behaviour with automatic payment
History
This supersedes and improves upon #1331 (an 16.0 PR by @adasatorres, which stuck open with unresolved test failures). It is a fresh 18.0 implementation that keeps the spirit — automatic token-based collection on the billing cron — while addressing its main limitations:
auto_create_paymentboolean instead of a new invoicing-mode option, so automatic payment composes with every mode(including Draft for silent billing) rather than being one mode.
owed invoice, never burns an invoice number, and the customer is never sent an "amount due" document for money already taken.
payment_exceptionflag, a to-do activity in list/kanban, an unchanged next-invoice date for retry, and a cron that skips flagged subscriptions — instead of silently falling back to manual collection.Credit to @adasatorres for the original PR