[19.0][IMP] contract: paginate contract lines on the form view#1465
Open
bosd wants to merge 1 commit into
Open
[19.0][IMP] contract: paginate contract lines on the form view#1465bosd wants to merge 1 commit into
bosd wants to merge 1 commit into
Conversation
The recurring/fixed contract line lists loaded every line at once, which slows down opening contracts with many lines. Add a list `limit` (80, Odoo's default backend list limit) so large contracts paginate instead of rendering all lines up front. Small contracts are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The contract form loads all contract lines at once. The recurring and fixed line lists (
contract_line_ids/contract_line_fixed_ids) had nolimit, so opening a contract with many lines rendered every line up front — noticeably slow on contracts with 50+ lines.Change
Add
limit="80"to both embedded line lists in the contract form view. 80 is Odoo's default backend list limit, so:Low risk, low effort — a view-only change, no Python/data changes.