[18.0][REF] contract_refund_on_stop - move last_date_invoiced into _create_refund_on_stop#1467
Open
anthonissen-a wants to merge 1 commit into
Open
Conversation
…reate_refund_on_stop
Contributor
|
Hi @sbejaoui, |
OCA-git-bot
added
series:18.0
mod:contract_refund_on_stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactoring to make the module easier to extend.
Moving the
last_date_invoicedupdate into_create_refund_on_stopis more coherent with the method’s responsibility and keeps the refund logic encapsulated.