[FIX] contract_sale_generation: Sale line violates check constraint#1478
Open
SirPyTech wants to merge 1 commit into
Open
[FIX] contract_sale_generation: Sale line violates check constraint#1478SirPyTech wants to merge 1 commit into
SirPyTech wants to merge 1 commit into
Conversation
Steps: 1. Create a contract with "Sale" generation type 2. Add a line without a product 3. Generate a sale from the contract Before this change: The sale cannot be created because it raises: > ValueError: <class 'psycopg2.errors.CheckViolation'>: "new row for relation "sale_order_line" violates check constraint "sale_order_line_accountable_required_fields" After this change: The line must have a product in order to save the contract.
OCA-git-bot
added
mod:contract_sale_generation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps:
Before this change:
The sale cannot be created because it raises:
After this change:
The line must have a product in order to save the contract.
Additional context:
The same issue was also addressed in #1100 but from a UI point of view