[18.0][FIX] contract: flush_recordset([create_date])#1480
Open
CristianoMafraJunior wants to merge 1 commit into
Open
[18.0][FIX] contract: flush_recordset([create_date])#1480CristianoMafraJunior wants to merge 1 commit into
CristianoMafraJunior wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a
MissingErrorraised when accessingrecord.create_dateinside_set_start_contract_modificationduring a fresh database installation withdemo data.
Root Cause
In Odoo 18, the
create()flow was redesigned to supportprecompute=Truefields. The new sequence is:
NewIdis assigned to the record (not yet in the database).precompute=Truefields are computed in memory.INSERTis executed, writing the record to the database.super().create()continues.create_dateis a database-generated value (set by PostgreSQL at INSERT time).The ORM does not precompute it, and in Odoo 18 it may not be loaded into
the ORM cache automatically after the INSERT returns.
When
_set_start_contract_modificationruns immediately aftersuper().create(), and the contract has no lines yet (e.g., when contracts arecreated before their lines in demo/fixture data), the code reaches: