[18.0][MIG] srm: Migration to 18.0#632
Conversation
vvrossem
force-pushed
the
18.0-add-srm
branch
from
107b94a to
7f6d65d
Compare
| @@ -65,34 +64,44 @@ | |||
| expr="//button[@name='action_sale_quotations_new']" | |||
| position="attributes" | |||
| > | |||
| <!-- addition to `type == 'lead' or probability == 0 and not active` --> | |||
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
|
hello @OCA/crm-sales-marketing-maintainers, could you please reopen this PR and set the no stale label? 🙏 |
simahawk
removed
the
stale
| @@ -0,0 +1,81 @@ | |||
| # Copyright 2022 Telmo Santos <telmo.santos@camptocamp.com> | |||
There was a problem hiding this comment.
| # Copyright 2022 Telmo Santos <telmo.santos@camptocamp.com> | |
| # Copyright 2022 Camptocamp SA | |
| # @author Telmo Santos <telmo.santos@camptocamp.com> |
everywhere
|
|
||
| def action_rfq_new(self): | ||
| action = self.env["ir.actions.actions"]._for_xml_id("srm.action_lead_rfq_new") | ||
| action["context"] = { |
There was a problem hiding this comment.
you should preserve the current context IMO
| "crm.lead", | ||
| string="Opportunity", | ||
| check_company=True, | ||
| domain="[('type', '=', 'opportunity'), ('request_type', '=', 'supplier'), '|', ('company_id', '=', False), ('company_id', '=', company_id)]", # noqa |
There was a problem hiding this comment.
It's from the previous PR: https://github.com/OCA/crm/pull/448/files#diff-927305c0e69968ef96e98841e1f08deda249ceb616f0a37c82185fe3faa59d11R14.
I'm adapting
| <!-- Lead Menu --> | ||
| <record id="srm_lead_action_pipeline" model="ir.actions.act_window"> | ||
| <field name="name">Srm: Pipeline</field> | ||
| <field name="res_model">crm.lead</field> |
There was a problem hiding this comment.
this file is a mix of views for different models... does it make sense?
| ========================================= | ||
| Sequential Code for Leads / Opportunities | ||
| ========================================= | ||
| ============ |
| "author": "Camptocamp, Odoo Community Association (OCA)", | ||
| "summary": "Use CRM model for suppliers", | ||
| "license": "AGPL-3", | ||
| "category": "CRM", |
There was a problem hiding this comment.
set dev status to Alpha (there's no test, for starting)
vvrossem
force-pushed
the
18.0-add-srm
branch
6 times, most recently
from
8ba2eb0 to
b7629ae
Compare
|
Hello @simahawk can you pls take a look again, it seems to be fixed? |
|
Hi @vvrossem , any chance to rebase ? |
Rebased, thanks |
Thank you 🙏 ! |
7 participants
Initial (closed)
14.0PR: #448