[19.0][MIG] crm_phonecall: migration to 19.0#712
Conversation
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
3 times, most recently
from
d0ec288 to
b5cae86
Compare
|
The precommit command fails because it does not seem to be up to date with the change in v19.0 of the "user_ids" attribute of the base model "ir.filters". This attribute has changed compared to v18.0, where it was "user_id". Here is the commit where the change can be seen: odoo/odoo@414e55c |
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
|
@eugenios73 could you review mine? #661 |
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
2 times, most recently
from
ebca7da to
d9fd486
Compare
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
4 times, most recently
from
f003208 to
a6a52fe
Compare
There was a problem hiding this comment.
I believe this type of contribution should be managed in a separate pull request. Then we can base this work on top of it.
|
This PR has the |
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
2 times, most recently
from
ffdb018 to
54ad4d8
Compare
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
from
54ad4d8 to
5c2cd3e
Compare
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
from
5c2cd3e to
b330973
Compare
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
2 times, most recently
from
c1fd0e7 to
4ead286
Compare
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
2 times, most recently
from
33cc26e to
78254fc
Compare
|
@OCA/crm-sales-marketing-maintainers Please, can you review/merge this PR? |
Currently translated at 100.0% (154 of 154 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (153 of 153 strings) Translation: crm-17.0/crm-17.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_phonecall/it/
Currently translated at 100.0% (153 of 153 strings) Translation: crm-17.0/crm-17.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_phonecall/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/
Currently translated at 99.3% (152 of 153 strings) Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/es/
Currently translated at 99.3% (152 of 153 strings) Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/es/
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
from
78254fc to
f3c3457
Compare
eugenios73
force-pushed
the
19.0-mig-crm_phonecall
branch
from
f3c3457 to
0f9cb21
Compare
|
@pedrobaeza The commit messages have been updated |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at fa90205. Thanks a lot for contributing to OCA. ❤️ |
20 participants
migration crm_phonecall from 18.0 to 19.0
The pre-commit-config update in commit [19.0][FIX] update pre-commit-config is to resolve the "user_id" error issue that was shown in the last pre-commit command and which I commented on in this message #712 (comment)