[MIG] [19.0] crm_lead_product: Migration to 19.0#739
Open
PieterPaulussen wants to merge 40 commits into
Open
Conversation
add filter for open opportunities in pipeline by product report [IMP] Extend test coverage
Currently translated at 100.0% (63 of 63 strings) Translation: crm-12.0/crm-12.0-crm_lead_product Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_product/es/
Currently translated at 100.0% (63 of 63 strings) Translation: crm-12.0/crm-12.0-crm_lead_product Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_product/ca/
* avoid conflict when testing a database with sale installed
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_lead_product Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_lead_product/
Currently translated at 100.0% (63 of 63 strings) Translation: crm-13.0/crm-13.0-crm_lead_product Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_lead_product/it/
Currently translated at 100.0% (63 of 63 strings) Translation: crm-13.0/crm-13.0-crm_lead_product Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_lead_product/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_lead_product Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_lead_product/
[MIG] crm_lead_product: Migration to 18.0
PieterPaulussen
force-pushed
the
19.0-mig-crm_lead_product
branch
6 times, most recently
from
aa929ba to
6f9ebbd
Compare
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks! Some minor comments.
luisDIXMIT
reviewed
Apr 21, 2026
PieterPaulussen
force-pushed
the
19.0-mig-crm_lead_product
branch
from
6f9ebbd to
2b3d9b7
Compare
PieterPaulussen
commented
Apr 23, 2026
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks for the updates! One small change remaining, for consistency.
About the prorated revenue, looks like that is because it is not being computed for 'lead' type leads, only opportunities. Maybe that's because in some older versions, the probability field was not visible on 'lead' type leads? Maybe good to update this logic as the proability field is visible and is populated predictively nowadays.
| if ( | ||
| not self.uom_id | ||
| or product.uom_id.category_id.id != self.uom_id.category_id.id | ||
| or product.uom_id.relative_uom_id.id != self.uom_id.relative_uom_id.id |
Member
There was a problem hiding this comment.
Here I would also check against allowed uoms rather than relative_uom_id. The field relative_uom_id is not used anywhere in business logic in Odoo 19.
luisDIXMIT
approved these changes
May 6, 2026
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and tested on runboat, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.