Skip to content

[18.0][MIG] website_event_ticket_limit#498

Merged
OCA-git-bot merged 4 commits intoOCA:18.0from
camptocamp:18.0-dev
Mar 23, 2026
Merged

[18.0][MIG] website_event_ticket_limit#498
OCA-git-bot merged 4 commits intoOCA:18.0from
camptocamp:18.0-dev

Conversation

@Highcooley
Copy link
Contributor

@Highcooley Highcooley commented Mar 19, 2026

No description provided.

@mmequignon
Copy link
Member

mmequignon commented Mar 22, 2026 •
edited
Loading

Looks like you squashed pre-commit changes in the translation commit (see readme changes in the second commit).
Those pre-commit changes belongs in their own commit.

Apart from that, code looks good

mmequignon
mmequignon requested changes Mar 23, 2026
View reviewed changes
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

mmequignon
mmequignon approved these changes Mar 23, 2026
View reviewed changes
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong button

divad1196
divad1196 approved these changes Mar 23, 2026
View reviewed changes
Copy link

@divad1196 divad1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good IMO

website_event_ticket_limit/i18n/fr.po
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 16.0\n"
Copy link

@divad1196 divad1196 Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical, but the version number says 16.0 instead of 18.0.
Same issue in other traduction files, but this is wrong in many other modules

meredith-alana
meredith-alana approved these changes Mar 23, 2026
View reviewed changes
Copy link

@meredith-alana meredith-alana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max works ✔️
Min doesn't, but is in another module and would have to be treated separately.
Also, not needed here.

@mmequignon
Copy link
Member

mmequignon commented Mar 23, 2026

/ocabot migration website_event_ticket_limit

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Mar 23, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 23, 2026
Open
23 tasks
@mmequignon
Copy link
Member

mmequignon commented Mar 23, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 23, 2026

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-498-by-mmequignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 979b71e into OCA:18.0 Mar 23, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 23, 2026

Congratulations, your PR was merged at f2e130c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmequignon mmequignon mmequignon approved these changes

+2 more reviewers

@divad1196 divad1196 divad1196 approved these changes

@meredith-alana meredith-alana meredith-alana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Highcooley @mmequignon @OCA-git-bot @divad1196 @meredith-alana @benj-filament