[19.0][MIG] account_invoice_margin: Migration to 19.0#270
Conversation
OCA-git-bot
added
mod:account_invoice_margin
dannyadair
left a comment
dannyadair
left a comment
There was a problem hiding this comment.
LGTM
identical to #254 except not touching .pylintrc
|
Hello @pedrobaeza , could you merge this PR, please? It supersedes the previous PR due to inactivity |
|
It requires an approval from a PSC/maintainer: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review |
|
/ocabot migration account_invoice_margin |
dreispt
left a comment
dreispt
left a comment
There was a problem hiding this comment.
Ideally the late fix commits should be squashed into one for a clean commit history.
|
Yes, please the commit history is very messed right now. |
|
Just to confirm, you’d like me to squash the last 6 fix commits into a single commit, correct? 
|
|
|
Rebase when I merge #271 |
|
You can now rebase and do the squashing/commit renaming. |
[UPD] README.rst [UPD] Update account_invoice_margin.pot Translated using Weblate (Spanish) Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-11.0/margin-analysis-11.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-11-0/margin-analysis-11-0-account_invoice_margin/es/
[UPD] README.rst
…t invoice margin security group set
[FIX] account_invoice_margin: Set purchase_price when user has not set invoice margin security group set
[REF] rename file with the name of the model [ADD] margins on account.invoice model (and related views) [ADD] description and screenshot [FIX] Typo on margin (%) field name [ADD] fr translation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/es/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-17.0/margin-analysis-17.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-17-0/margin-analysis-17-0-account_invoice_margin/it/
Alexis-SDK
force-pushed
the
19.0-mig-account-invoice-margin
branch
3 times, most recently
from
e5d1854 to
1d872e7
Compare
|
Is this okay for you? @dreispt |
|
You have overriden the attribution of the work of the rest. I put before that expected squashing. |
Alexis-SDK
force-pushed
the
19.0-mig-account-invoice-margin
branch
from
1d872e7 to
c79acb6
Compare
|
@pedrobaeza Is that better for you? |
|
OK, let's continue that way with the co-authorship. /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 367ed2c. Thanks a lot for contributing to OCA. ❤️ |
20 participants
This is a new merge request as the previous one is not progressing, and waiting further would waste time
superseeded #254