Skip to content

[16.0][FIX] copier update from 1.29 to 1.43#273

Merged
pedrobaeza merged 1 commit into
OCA:16.0from
grap:16.0-FIX-sale_margin_delivered-E221-SLG
Jun 18, 2026
Merged

[16.0][FIX] copier update from 1.29 to 1.43#273
pedrobaeza merged 1 commit into
OCA:16.0from
grap:16.0-FIX-sale_margin_delivered-E221-SLG

Conversation

@legalsylvain

@legalsylvain legalsylvain commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

copier update from 1.29 to 1.43

Try to fix pre-commit issue, bumping copier update :
Ex : #272

@OCA-git-bot

OCA-git-bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Hi @Shide, @sergio-teruel,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:sale_margin_delivered Module sale_margin_delivered series:16.0 mod:account_invoice_margin Module account_invoice_margin mod:sale_margin_sync Module sale_margin_sync mod:sale_margin_delivered_dropshipping Module sale_margin_delivered_dropshipping mod:product_replenishment_cost Module product_replenishment_cost mod:product_standard_margin Module product_standard_margin mod:sale_margin_delivered_security Module sale_margin_delivered_security mod:sale_margin_security Module sale_margin_security mod:sale_report_margin Module sale_report_margin mod:product_standard_margin_security Module product_standard_margin_security labels Jun 18, 2026
@legalsylvain legalsylvain changed the title [FIX] sale_margin_delivered: Error 221 [FIX] sale_margin_delivered: Error 221 + copier update Jun 18, 2026
@legalsylvain

legalsylvain commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

hi @OCA/accounting-maintainers Could you take a look and merge this PR that fixes current red CI ?

thanks !

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 18, 2026
@pedrobaeza pedrobaeza changed the title [FIX] sale_margin_delivered: Error 221 + copier update [16.0][FIX] sale_margin_delivered: Error 221 + copier update Jun 18, 2026
@pedrobaeza

pedrobaeza commented Jun 18, 2026

Copy link
Copy Markdown
Member

I think you should separate the fix from the copier update. If not, launching ocabot with patch will raise a lot of module versions without need, and putting nobump will have no raise in the affected module. And are you sure that README change will not be undone by the bot? It has its own special version for doing that, so the other possibility is just to not change READMEs at all.

sergiocorato
sergiocorato requested changes Jun 18, 2026
View reviewed changes
Comment thread sale_margin_delivered/reports/sale_report.py Outdated
/ {self._case_value_or_one('s.currency_rate')}
* {self._case_value_or_one('currency_table.rate')})
"""
res["margin_delivered"] = (

@sergiocorato sergiocorato Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part in v. 18.0 is the same and it doesn't throw errors, could you split this change in another PR and commit only copier update?

@legalsylvain legalsylvain Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. This line generate a E221 error.

Done

@legalsylvain legalsylvain force-pushed the 16.0-FIX-sale_margin_delivered-E221-SLG branch from e93c3cc to dd95cd6 Compare June 18, 2026 16:34
@OCA-git-bot OCA-git-bot removed mod:account_invoice_margin Module account_invoice_margin mod:sale_margin_sync Module sale_margin_sync mod:sale_margin_delivered_dropshipping Module sale_margin_delivered_dropshipping mod:product_replenishment_cost Module product_replenishment_cost mod:product_standard_margin Module product_standard_margin mod:sale_margin_delivered_security Module sale_margin_delivered_security mod:sale_margin_security Module sale_margin_security mod:sale_report_margin Module sale_report_margin mod:product_standard_margin_security Module product_standard_margin_security labels Jun 18, 2026
@legalsylvain legalsylvain force-pushed the 16.0-FIX-sale_margin_delivered-E221-SLG branch from dd95cd6 to ff6d8c0 Compare June 18, 2026 16:36
@legalsylvain legalsylvain changed the title [16.0][FIX] sale_margin_delivered: Error 221 + copier update [16.0][FIX] copier update from 1.29 to 1.43 Jun 18, 2026
@legalsylvain

legalsylvain commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

I think you should separate the fix from the copier update. If not, launching ocabot with patch will raise a lot of module versions without need, and putting nobump will have no raise in the affected module. And are you sure that README change will not be undone by the bot? It has its own special version for doing that, so the other possibility is just to not change READMEs at all.

indeed ! done.

pedrobaeza
pedrobaeza approved these changes Jun 18, 2026
View reviewed changes

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this directly, as it doesn't need ocabot.

@pedrobaeza pedrobaeza merged commit 6d36871 into OCA:16.0 Jun 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergiocorato sergiocorato sergiocorato requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees

No one assigned

Labels

mod:sale_margin_delivered Module sale_margin_delivered series:16.0

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@legalsylvain @OCA-git-bot @pedrobaeza @sergiocorato