[17.0][MIG] pos_payment_change by em230418 · Pull Request #1331 · OCA/pos

em230418 · 2025-03-13T12:49:53Z

No description provided.

- Black python code - OCA Convention - Add tests - add configuration on pos.config, with two option 'refund' or 'update' - The 'refund' option makes the module compatible with (French) certification - make the module compatible with pos_order_return

…on PoS Order(s) to know the history of the payments

…ontrol ; [ADD] display old payment lines

Currently translated at 100.0% (31 of 31 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

add new line Pylint fix pylint

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/de/

A cash payment method must have a cash journal.

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/fr/

In old version, two certifications modules was present in odoo. l10n_fr_pos_cert and l10n_fr_certification. In odoo 16, only l10n_fr_pos_cert exists.

github-actions · 2026-02-01T13:00:38Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

em230418 · 2026-02-16T07:13:58Z

so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.

Please no

cvinh · 2026-02-16T17:22:10Z

@em230418 maybe you can rebase to unlock runboat. Then your PR can be tested by reviewers

etobella · 2026-02-16T18:12:16Z

/ocabot rebase

OCA-git-bot · 2026-02-16T18:12:26Z

Congratulations, PR rebased to 17.0.

cvinh

Tested on runboat LGTM
There's a small issue (it's not because of the migration) when you select a refunded order in the frontend : the 3 orders get selected at once and the original one opens.
Then we want an invoice, the invoice is linked to the original one.
Maybe you can add this in the roadmap part of the readme

ilmir-k · 2026-02-17T13:27:09Z

LGTM

ivantodorovich

/ocabot migration pos_payment_change
/ocabot merge nobump

OCA-git-bot · 2026-04-09T15:50:18Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1331-by-ivantodorovich-bump-nobump, awaiting test results.

Signed-off-by ivantodorovich

OCA-git-bot · 2026-04-09T15:59:53Z

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1331-by-ivantodorovich-bump-nobump, awaiting test results.

Signed-off-by ivantodorovich

OCA-git-bot · 2026-04-09T16:09:09Z

@ivantodorovich The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name pos --branch 17.0 --addons-dir /tmp/tmpoqdmvk4c --commit failed with output:

/tmp/tmpoqdmvk4c/pos_payment_change/README.rst:96: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 6, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1485, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1406, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1269, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 824, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 465, in publish_file
    output, _publisher = publish_programmatically(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 794, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 269, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 95, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 101, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 185, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 182, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 234, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 446, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2487, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2499, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2215, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.12/site-packages/docutils/nodes.py", line 2063, in note_substitution_def
    msg = self.reporter.error(
          ^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 256, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 217, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpoqdmvk4c/pos_payment_change/README.rst:96: (ERROR/3) Duplicate substitution definition name: "image1".

ivantodorovich · 2026-04-09T17:59:31Z

@em230418 can you fix the issue reported above? 🙏🏻

…licit rights

em230418 · 2026-04-13T07:18:03Z

@em230418 can you fix the issue reported above? 🙏🏻

Done. The only thing I did that probably fixes the problem is recreating README.rst via pre-commit.
Result diff looks like this:

diff --git a/pos_payment_change/README.rst b/pos_payment_change/README.rst
index e6291f5..0be6e68 100644
--- a/pos_payment_change/README.rst
+++ b/pos_payment_change/README.rst
@@ -7,7 +7,7 @@ Point Of Sale - Change Payments
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:6881f0be1df613c788f593eed6eefeb05567b3991680bf98bcd8497749e53a1a
+   !! source digest: sha256:1c6e8c040d05dda8166904f53fc0ab8ba31c3e0fc1d9c158284f6dbd75c966c4
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png

legalsylvain and others added 30 commits March 13, 2025 15:54

[IMP] use refund() to resale order (in 'refund' mode) ; [ADD] a note …

64add20

…on PoS Order(s) to know the history of the payments

[FIX] error in balance computation if change is done during closing c…

5c1c8bb

…ontrol ; [ADD] display old payment lines

Update __manifest__.py

bdf6b87

[FIX] access to ir.module.module should be done with sudo

6116a64

Added translation using Weblate (Spanish)

06fb3aa

Translated using Weblate (Spanish)

c809b5e

Currently translated at 100.0% (31 of 31 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Use currency and monetary so that rounding will be done by the ORM*

8df68c3

add new line Pylint fix pylint

more fix pyilint

932f837

Translated using Weblate (Spanish)

dd8f2db

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Added translation using Weblate (German)

32b1569

Translated using Weblate (German)

6d4d641

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/de/

[IMP] pos_payment_change: isort, black, prettier.

4515041

[MIG] Migrate module pos_payment_change to v14.

1dfa89a

[FIX] pos_payment_change: fix test

386da46

A cash payment method must have a cash journal.

[MIG]pos_payment_change: Migration to 15.0

214258c

[WIP] pos_payment_change: Migration to 16.0

d9419cf

[FIX] the method _check_pos_session_balance is deleted in point_of_sale

b6b6965

[FIX] use float_compare to compare floats

4dc3018

[MIG] pos_payment_change: modification wizard view, add widget selection

e2b0f33

[UPD] Update pos_payment_change.pot

ebdfb77

[UPD] README.rst

b7c540a

Translated using Weblate (Spanish)

2583f0e

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/

Added translation using Weblate (Italian)

d341df9

Translated using Weblate (Italian)

d063e14

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/it/

[UPD] README.rst

03c6043

Update translation files

037b235

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/

Translated using Weblate (Spanish)

3df18b9

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/

Translated using Weblate (French)

159b82a

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/fr/

[FIX] pos_payment_change : check installation fo existing modules.

18a0115

In old version, two certifications modules was present in odoo. l10n_fr_pos_cert and l10n_fr_certification. In odoo 16, only l10n_fr_pos_cert exists.

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 28, 2025

Abranes mentioned this pull request Nov 9, 2025

[18.0][MIG] pos_payment_change: Migration to 18.0 #1453

Open

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 1, 2026

OCA-git-bot force-pushed the 17.0-mig-pos_payment_change branch from c55607c to f0e61de Compare February 16, 2026 18:12

cvinh suggested changes Feb 16, 2026

View reviewed changes

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 22, 2026

ivantodorovich approved these changes Apr 9, 2026

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Apr 9, 2026

OCA-git-bot added a commit that referenced this pull request Apr 9, 2026

Merge PR #1331 into 17.0

058f5a2

Signed-off-by ivantodorovich

OCA-git-bot mentioned this pull request Apr 9, 2026

Migration to version 17.0 #1077

Open

35 tasks

OCA-git-bot added the bot is merging ⏳ label Apr 9, 2026

OCA-git-bot added a commit that referenced this pull request Apr 9, 2026

Merge PR #1331 into 17.0

ee5936e

Signed-off-by ivantodorovich

OCA-git-bot removed the bot is merging ⏳ label Apr 9, 2026

em230418 added 5 commits April 13, 2026 12:15

[IMP] pos_payment_change: pre-commit auto fixes

b208b01

[MIG] pos_payment_change: Migration to 17.0

6bc96ef

[FIX] pos_payment_change: rebase test on TestPoSCommon

2bfa862

[FIX] pos_payment_change: in tests replace Marc Demo to user with exp…

30e31ea

…licit rights

[FIX] pos_payment_change: add compatibility with pos_order_copy

593cff8

em230418 force-pushed the 17.0-mig-pos_payment_change branch from f0e61de to 593cff8 Compare April 13, 2026 07:16

Uh oh!

Conversation

em230418 commented Mar 13, 2025

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

em230418 commented Feb 16, 2026

Uh oh!

cvinh commented Feb 16, 2026

Uh oh!

etobella commented Feb 16, 2026

Uh oh!

OCA-git-bot commented Feb 16, 2026

Uh oh!

cvinh left a comment

Choose a reason for hiding this comment

Uh oh!

ilmir-k commented Feb 17, 2026

Uh oh!

ivantodorovich left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 9, 2026

Uh oh!

OCA-git-bot commented Apr 9, 2026

Uh oh!

OCA-git-bot commented Apr 9, 2026

Uh oh!

ivantodorovich commented Apr 9, 2026

Uh oh!

em230418 commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants