Open
Conversation
Currently translated at 100.0% (80 of 80 strings) Translation: foodcoops-12.0/foodcoops-12.0-pos_automatic_cashdrawer Translate-URL: https://translate.druidoo.io/projects/foodcoops-12-0/foodcoops-12-0-pos_automatic_cashdrawer/fr/
P-H-Phuc
force-pushed
the
18.0-mig-pos_automatic_cashdrawer
branch
from
7056006 to
71efdf0
Compare
ivantodorovich
requested changes
Apr 9, 2026
Contributor
ivantodorovich
left a comment
ivantodorovich
left a comment
There was a problem hiding this comment.
Thanks!
IMO the module name is too generic for the OCA, though.
There are lots of cashdrawers out there, and AFAIR this module only works for one of them: cashlogy
If we just rename the module to pos_automatic_cashdrawer_cashlogy it would be OK, IMO.
In the future, if people is interested in implementing other brands, a common base module could be factorized
Contributor
There was a problem hiding this comment.
Please remove to let the standard OCA module take over
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module was initially part of the Foodcoop set of addons. We're now migrating it to 18.0 and taking this occasion to contribute it to OCA.