Open
Conversation
mihien
force-pushed
the
16.0-add-pos_product_unmodifiable_price
branch
2 times, most recently
from
022e077 to
bead5a7
Compare
mihien
force-pushed
the
16.0-add-pos_product_unmodifiable_price
branch
from
bead5a7 to
6136529
Compare
4 tasks
huguesdk
suggested changes
Apr 1, 2026
pos_product_fixed_price/static/src/js/Screens/ProductScreen/ProductScreen.esm.js
Show resolved
Hide resolved
| set_unit_price(price) { | ||
| // Price is not assigned on line creation and empty on line deletion | ||
| if (this.price && price !== "") { | ||
| if (this.product.is_pos_price_fix && this.price !== price) { |
Member
There was a problem hiding this comment.
in which case is this true? it doesn’t seem possible to happen, as the price can only be modified when the numpad is in price mode, which cannot happen on this product. is this whole method actually useful?
| class extends OriginalOrderline { | ||
| set_unit_price(price) { | ||
| // Price is not assigned on line creation and empty on line deletion | ||
| if (this.price && price !== "") { |
Member
There was a problem hiding this comment.
price is equal to "" only when the numpad is in price mode and the backspace key is used. in quantity mode it is never set to this value.
Suggested change
| if (this.price && price !== "") { | |
| if (this.price) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Products can be set as having a fixed price in the PoS, meaning users can't change its price from the PoS interface.