[18.0][MIG] pos_payment_method_cashdro: Migration to version 18.0#1522
[18.0][MIG] pos_payment_method_cashdro: Migration to version 18.0#1522eduezerouali-tecnativa wants to merge 12 commits intoOCA:18.0from
Conversation
This module allows to make payments with a Cashdro (https://www.cashdro.com) terminal on the Point of Sale frontend. TT29224
Overcome floting point issues: https://stackoverflow.com/a/588014 For expample 2.3 * 100 -> 229.99999999999997 TT42574
Currently translated at 100.0% (8 of 8 strings) Translation: pos-14.0/pos-14.0-pos_payment_method_cashdro Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_payment_method_cashdro/it/
Currently translated at 100.0% (6 of 6 strings) Translation: pos-16.0/pos-16.0-pos_payment_method_cashdro Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_method_cashdro/it/
Give the user the ability to chose between http and https.
eduezerouali-tecnativa
force-pushed
the
18.0-mig-pos_payment_method_cashdro
branch
from
15e72ea to
9194ec8
Compare
|
/ocabot migration pos_payment_method_cashdro |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Code review and test of the failing connection in runboat.
pos_payment_method_cashdro/static/src/js/payment_cashdro.esm.js
Outdated
Show resolved
Hide resolved
ivantodorovich
left a comment
ivantodorovich
left a comment
There was a problem hiding this comment.
pre-approving. pending removal of console.log statements
eduezerouali-tecnativa
force-pushed
the
18.0-mig-pos_payment_method_cashdro
branch
from
9194ec8 to
ab803b9
Compare
|
Please attend JS linter warnings. It seems touching that, it opens the Pandora box... |
|
Working on it |
eduezerouali-tecnativa
force-pushed
the
18.0-mig-pos_payment_method_cashdro
branch
from
ab803b9 to
6a4c251
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
eduezerouali-tecnativa
force-pushed
the
18.0-mig-pos_payment_method_cashdro
branch
from
6a4c251 to
0f121eb
Compare
|
Congratulations, your PR was merged at 9058866. Thanks a lot for contributing to OCA. ❤️ |
|
@eduezerouali-tecnativa the last change hasn't been merged, and now the PR appears as closed instead of merged. If it's needed, please open a new PR. |
|
Not really needed, but i think it could be an improve as that check was for |
|
OK, then you can add a new IMP PR, and next time, if the merge command has been launched, you can tell me for aborting the merge. |
Did not knew that, plus I did not get the notification on time. |
7 participants
cc @Tecnativa TT57259
Standard Migration
ping @pedrobaeza @victoralmau