Skip to content

[18.0][ADD] rma_batch_reason: add new module to link batch and reason behaviors#534

Open
StephaneMangin wants to merge 1 commit intoOCA:18.0from
acsone:18.0_add_rma_batch_reason
Open

[18.0][ADD] rma_batch_reason: add new module to link batch and reason behaviors#534
StephaneMangin wants to merge 1 commit intoOCA:18.0from
acsone:18.0_add_rma_batch_reason

Conversation

@StephaneMangin
Copy link

No description provided.

@StephaneMangin StephaneMangin changed the title [18.0][ADD] rma_batch_reason: add new module to link batch and reason bahaviors [18.0][ADD] rma_batch_reason: add new module to link batch and reason behaviors Feb 10, 2026
@StephaneMangin StephaneMangin force-pushed the 18.0_add_rma_batch_reason branch from bdf02ec to 2fd473d Compare February 10, 2026 10:49
@StephaneMangin
Copy link
Author

Dependency on #499

@StephaneMangin StephaneMangin force-pushed the 18.0_add_rma_batch_reason branch 10 times, most recently from 4300a9a to 714a404 Compare February 10, 2026 11:58
@StephaneMangin
Copy link
Author

Failed tests due to an indirect dependency to rma_sale which is not on this module dependency scope but in the repository.

@yvaucher
Copy link
Member

yvaucher commented Feb 10, 2026

For the tests I recommend to test if sale module might be installed and thus provide sale_line_warn value in that case to improve robustness of the tests.

@StephaneMangin StephaneMangin force-pushed the 18.0_add_rma_batch_reason branch 2 times, most recently from 1153c36 to e8b4245 Compare February 10, 2026 13:45
@StephaneMangin StephaneMangin marked this pull request as ready for review February 10, 2026 13:51
@StephaneMangin
Copy link
Author

StephaneMangin commented Feb 10, 2026

For the tests I recommend to test if sale module might be installed and thus provide sale_line_warn value in that case to improve robustness of the tests.

Without the test-requirements for rma_batch which has just been merged, everything passed green !

@StephaneMangin StephaneMangin force-pushed the 18.0_add_rma_batch_reason branch 7 times, most recently from 77e9524 to eca53c9 Compare February 10, 2026 15:04
@StephaneMangin StephaneMangin force-pushed the 18.0_add_rma_batch_reason branch from eca53c9 to e926566 Compare February 10, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants