[18.0][IMP] rma: Define the expected configuration (action_create_* fields) in operations#544
Open
victoralmau wants to merge 4 commits intoOCA:18.0from
Open
[18.0][IMP] rma: Define the expected configuration (action_create_* fields) in operations#544victoralmau wants to merge 4 commits intoOCA:18.0from
victoralmau wants to merge 4 commits intoOCA:18.0from
Conversation
Contributor
|
Hi @pedrobaeza, @peluko00, @chienandalu, |
victoralmau
force-pushed
the
18.0-imp-rma-operation_data
branch
2 times, most recently
from
eaf49cd to
9206d1c
Compare
pedrobaeza
approved these changes
Mar 26, 2026
carlos-lopez-tecnativa
approved these changes
Mar 26, 2026
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
LGTM
I think the operation_id field should be read-only when the RMA flow is finished. Currently, I can change this field, which can be confusing, and no trace is left in the chatter. Please consider adding tracking to the field or making it read-only at some point in the flow.
Contributor
|
This PR has the |
… in operations Replace: Not refund Repair: Not refund Refund: Not delivery
victoralmau
force-pushed
the
18.0-imp-rma-operation_data
branch
from
9206d1c to
5d54b58
Compare
victoralmau
force-pushed
the
18.0-imp-rma-operation_data
branch
from
5d54b58 to
39badbb
Compare
carlos-lopez-tecnativa
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the expected configuration (action_create_* fields) in operations
Replace: Not refund
Repair: Not refund
Refund: Not delivery
Add tracking=True to operation_id field + Do not allow the operation_id field to be modified if it is already "completed"
Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?
@Tecnativa