Skip to content

[16.0] add base_external_system_ms_client_assertion#289

Open
NL66278 wants to merge 23 commits intoOCA:16.0from
Therp:16.0-add-base_external_system_ms_client_assertion
Open

[16.0] add base_external_system_ms_client_assertion#289
NL66278 wants to merge 23 commits intoOCA:16.0from
Therp:16.0-add-base_external_system_ms_client_assertion

Conversation

@NL66278
Copy link
Copy Markdown
Contributor

@NL66278 NL66278 commented May 14, 2024

No description provided.

@NL66278 NL66278 force-pushed the 16.0-add-base_external_system_ms_client_assertion branch from e22688b to c458b29 Compare May 15, 2024 14:36
ntsirintanis
ntsirintanis reviewed May 21, 2024
View reviewed changes
Comment thread base_external_system_oauth/models/auth_oauth_provider.py Outdated
@NL66278 NL66278 force-pushed the 16.0-add-base_external_system_ms_client_assertion branch from c9145b2 to ea7dd5f Compare May 22, 2024 08:06
@NL66278 NL66278 force-pushed the 16.0-add-base_external_system_ms_client_assertion branch 2 times, most recently from 1155011 to 990b53f Compare May 29, 2024 12:12
@NL66278 NL66278 changed the title [WIP][16.0] add base_external_system_ms_client_assertion [16.0] add base_external_system_ms_client_assertion Oct 7, 2024
@NL66278
Copy link
Copy Markdown
Contributor Author

NL66278 commented Oct 7, 2024

For some time now successfully running in production at large customer.

This was referenced Oct 22, 2024
Closed
Closed
SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#289 from OCA/16.0
1f18821 
Syncing from upstream OCA/server-backend (16.0)
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 23, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 23, 2025
@NL66278
Copy link
Copy Markdown
Contributor Author

NL66278 commented Mar 24, 2025

@thomaspaulb Could you add a no stale label here?

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 30, 2025
lfreeke
lfreeke approved these changes Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown

@lfreeke lfreeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This have been working without issues for our customer

@NL66278 NL66278 force-pushed the 16.0-add-base_external_system_ms_client_assertion branch from 584630c to cbe2e26 Compare September 3, 2025 11:02
@NL66278 NL66278 mentioned this pull request Sep 3, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 4, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 4, 2026
@thomaspaulb thomaspaulb added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jan 5, 2026
@thomaspaulb
Copy link
Copy Markdown

thomaspaulb commented Jan 5, 2026

@NL66278 Sorry, this can't be merged in its current form. It's too many things at once, and covers 4 different modules.

Can we start by opening up a PR to base_external_system, with the refactors that are being done there? Add a description to the PR with checkboxes for each of the things that are added, and the source PR where it comes from (I can't find it, at least it was never merged)

@NL66278
Copy link
Copy Markdown
Contributor Author

NL66278 commented Jan 5, 2026

@thomaspaulb There was this one #281 that was also never merged. All of this is running in production, alt multiple clients, without any problems.

@NL66278
Copy link
Copy Markdown
Contributor Author

NL66278 commented Jan 27, 2026

@thomaspaulb OK, so here is the first PR for the base module. When that is merged, I will provide, one by one, PR's for the additional modules.

@NL66278
Copy link
Copy Markdown
Contributor Author

NL66278 commented Feb 9, 2026

@thomaspaulb Here is the actual link to the first PR, the one to make the base module extendable, #414

NL66278 and others added 20 commits March 31, 2026 13:37
@NL66278
[IMP] base_external_system_http: pre-commit stuff
5c09d90
@NL66278
[MIG] base_external_system_http: Migration to 16.0
e8280f9
@NL66278
[ADD] base_external_system_oauth: new module
9696411
@NL66278
[IMP] base_external_system_oauth: pre-commit stuff
6ddc8fb
@NL66278
[MIG] base_external_system_oath: migration to 16.0
b8c7306
@NL66278
[IMP] *-system_oauth: provide tests
1d79d9b
@NL66278
[ADD] base_external_system_ms_client_assertion: new module
64af32b
@NL66278
[TST] ..client_assertion: remove for now actual connection test
103787e
@NL66278
[FIX] base_..._oauth: no need for basic type provider.
27572cd 
Basic authentication is no oauth at all and fully handled by base_external_system_http.
@NL66278
[IMP] base_..assertion: optionally use private_key value as is
888b3e5 
In some installations, especially odoo.sh, it is not possible for the Odoo admin to put
files like the private key in the filesystem. In that case the private key can be pasted
into the private key field, and the value will be used and not interpreted as a filename.
@NL66278
[IMP] base_...assertion: add the xt5 header
d3704d7
@ntsirintanis @NL66278
[FIX] retrieve headers from kwargs
f231f84
@ntsirintanis @NL66278
[FIX] base_external_system_ms_client_assertion: type in _set_headers
ec8f53a
@ntsirintanis @NL66278
[FIX] base_external_system_oauth: add headers in kwargs
b201927
@NL66278
[FIX] base_..._oauth: more pre-commit stuff
dd805ad
@NL66278
[FIX] ..oauth: problem with setting token variable
3e1768d
@NL66278
[FIX] base_external_system: previous_dir now also property
f395535
@NL66278
[FIX] base_external..: should be possible to override timeout
b8dee6d
@NL66278
[FIX] base_external..: prevent excessive logging
80a9ae8
@NL66278
[FIX] restore basic oauth connection
424dd6b
@NL66278 NL66278 force-pushed the 16.0-add-base_external_system_ms_client_assertion branch from cbe2e26 to 424dd6b Compare March 31, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lfreeke lfreeke lfreeke approved these changes

@ntsirintanis ntsirintanis ntsirintanis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NL66278 @thomaspaulb @lfreeke @ntsirintanis @OCA-git-bot