Skip to content

[18.0][IMP] base_external_dbsource_mssql: commit on inserts #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JordiMForgeFlow wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+4 −0
Open

[18.0][IMP] base_external_dbsource_mssql: commit on inserts #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions base_external_dbsource_mssql/models/base_external_dbsource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,8 @@ def _execute_mssql(self, sqlquery, sqlparams, metadata):
# If the query doesn't return rows, trying to get them anyway
# will raise an exception `sqlalchemy.exc.ResourceClosedError`
rows = [r for r in cur] if cur.returns_rows else []
# cur.returns_rows is False for DML (INSERT/UPDATE/DELETE),
# which need an explicit commit to persist changes.
if not cur.returns_rows:
connection.commit()
return rows, cols
Loading