[16.0][MIG] storage_backend_ftp: Migration to 16.0#553
Open
[16.0][MIG] storage_backend_ftp: Migration to 16.0#553
Conversation
* list should return a python list of files. * get should get and directly return the bynary from the FTP. Before, a string was being retrived and then encoded. This is problematic if the original binary was not utf-8.
- Add timeout to FTP connections (OCA pylint requirement)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of storage_backend_ftp to 16.0
Changes
Testing
Recreated from previous PR #551 (closed to migrate from personal fork to organization fork)