Fix false warning IMPLIED PIC#288
Open
RamyGeorge wants to merge 1 commit into
Open
Conversation
GitMensch
requested changes
Apr 27, 2026
GitMensch
left a comment
GitMensch
left a comment
Collaborator
There was a problem hiding this comment.
there is only 1 part missing: cobc/field.c, then it can go upstream - ideally with the minor things noted here finished
Can you please either do a follow-up commit or push a revised version (doesn't make a difference for upstream) with that?
| cb_tree first_value = get_first_value (f); | ||
| if (first_value && CB_NUMERIC_LITERAL_P (first_value)) { | ||
| const cb_tree x = CB_TREE (f); | ||
| if (f->pic){ |
Collaborator
There was a problem hiding this comment.
minor formatting; space after )
Comment on lines
+915
to
+918
| WORKING-STORAGE SECTION. | ||
| 01 x PIC X. | ||
| 01 num PIC 9. | ||
|
|
Collaborator
There was a problem hiding this comment.
those are not used, so the four lines should be deleted
Collaborator
There was a problem hiding this comment.
that file wasn't changed in a long time - please add , 2026 to the file's header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://sourceforge.net/p/gnucobol/discussion/help/thread/941d670883/
False IMPLIED PIC