Fix spy favorites showing numeric IDs instead of player/alliance names

[Copilot]

get_favoriteSpyList() was selecting player.ally_id and astro.player_id (integer FKs) into the ally and player display fields, so the favorites view rendered raw numeric IDs instead of names.

Changes

• model/Spy_Model.php — get_favoriteSpyList()
  • Replace astro.player_id → player.name AS player_name (player table already JOINed)
  • Replace player.ally_id → ally.name AS ally_name
  • Add LEFT JOIN TABLE_GAME_ALLY ally ON player.ally_id = ally.id (LEFT to preserve players without an alliance)
  • Alias user.name AS user_name to disambiguate duplicate name columns

// Before
$request = "SELECT pspy.`id`, ..., `player`.`ally_id`, `astro`.`player_id`, `player`.`status`";
$request .= " INNER JOIN " . TABLE_GAME_PLAYER . " `player` ON `astro`.`player_id` = `player`.`id`";
// No ally join — ally_id was an unresolved FK

// After
$request = "SELECT pspy.`id`, ..., `ally`.`name` AS `ally_name`, `player`.`name` AS `player_name`, `player`.`status`";
$request .= " INNER JOIN " . TABLE_GAME_PLAYER . " `player` ON `astro`.`player_id` = `player`.`id`";
$request .= " LEFT JOIN "  . TABLE_GAME_ALLY   . " `ally`   ON `player`.`ally_id`  = `ally`.`id`";

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Fixes the spy favorites list so it displays player/alliance names (instead of numeric FK IDs) by selecting the proper name columns and adding the missing alliance join.

Changes:

• Update get_favoriteSpyList() SELECT to return player.name / ally.name for display.
• Add LEFT JOIN to the alliance table to resolve player.ally_id into an alliance name.
• Alias user.name as user_name to avoid ambiguity among multiple name columns.

[Copilot]

ORDER BY uses $ordered_by values like ally, player, and coordinates, but the query no longer has columns/aliases with those names (it selects ally_name / player_name, and coordinates are split across astro.galaxy/system/row). As a result, clicking the sort links in views/home_spy.php (sort=1..4) will produce an SQL error (Unknown column ... in order clause) or sort incorrectly. Update the $ordered_by mapping to real SQL expressions/aliases (e.g., astro.galaxy, astro.system, astro.row for coordinates; ally.name/ally_name; player.name/player_name; and astro.type for moon).