Update roxygen2 comments, unit tests and fix errors#322
Merged
anthonysena merged 3 commits intodatabase-covariate-storagefrom Feb 26, 2026
Merged
Conversation
… to properly pass off parameters to covariate builder functions
anthonysena
added a commit
that referenced
this pull request
Mar 2, 2026
* Made commented sqlite test for old code work * Changes to interface of getDefaultCovariates * Fixes, restoration of old parameters and adaptation to use temp tables * Creating/dropping or appending results checked. Added details to news * whitespace * Fix merge problems * Remove debugging message * Restore warning for post-coordinated concept collision * fixing export FE to database - letting users export to a set of database tables instead of downloading to Andromeda * Update CreateExportTables.sql fixing time_ref columns * changing temp table insert * Update GetDefaultCovariates.R * Update DemographicsTime.sql explicitly specifying where the observation_period_ columns come from just in case the cohort table has these are columns * Update DemographicsTime.sql missed period_id * Update GetDefaultCovariates.R fixing oracleTempSchema being used * Update roxygen2 comments, unit tests and fix errors (#322) * Updates to remove unnecessary tests, add back collision detection and to properly pass off parameters to covariate builder functions * Update docs * Fix parameter documentation and example * Bump version and date in description and update news.md --------- Co-authored-by: Anthony Sena <asena5@its.jnj.com> Co-authored-by: jreps <jreps@its.jnj.com> Co-authored-by: Anthony Sena <anthonysena@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.