Skip to content

minor fixes#140

Open
p-hoffmann wants to merge 4 commits intomainfrom
p-hoffmann/pool
Open

minor fixes#140
p-hoffmann wants to merge 4 commits intomainfrom
p-hoffmann/pool

Conversation

@p-hoffmann
Copy link
Copy Markdown
Member

This pull request introduces two main changes: it updates the workflow triggers in the GitHub Actions configuration and simplifies the implementation of the SupervisorPolicy enum in Rust by leveraging the Default derive macro. These changes help streamline CI/CD processes and reduce boilerplate code.

Copilot AI review requested due to automatic review settings March 14, 2026 09:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines configuration and defaults across the repo by (1) adjusting CI workflow triggers/registries and (2) reducing Rust boilerplate by deriving Default for SupervisorPolicy.

Changes:

  • Derive Default for SupervisorPolicy using #[default] on the enum variant (removes manual impl).
  • Update npm registry configuration to point @trex to the trex Azure Artifacts feed.
  • Modify the D2E integration workflow triggers (remove paths filters; add merge_group).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
crates/base/src/worker/pool.rs Replace manual Default impl with #[derive(Default)] + #[default] variant.
.npmrc Update @trex registry to the trex feed.
.github/workflows/plugin-ci.yml Update setup-node registry URL for OSS develop publishing to match the trex feed.
.github/workflows/d2e-integration.yml Broaden workflow triggers and add merge_group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants