Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines configuration and defaults across the repo by (1) adjusting CI workflow triggers/registries and (2) reducing Rust boilerplate by deriving Default for SupervisorPolicy.
Changes:
- Derive
DefaultforSupervisorPolicyusing#[default]on the enum variant (removes manual impl). - Update npm registry configuration to point
@trexto thetrexAzure Artifacts feed. - Modify the D2E integration workflow triggers (remove
pathsfilters; addmerge_group).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/base/src/worker/pool.rs |
Replace manual Default impl with #[derive(Default)] + #[default] variant. |
.npmrc |
Update @trex registry to the trex feed. |
.github/workflows/plugin-ci.yml |
Update setup-node registry URL for OSS develop publishing to match the trex feed. |
.github/workflows/d2e-integration.yml |
Broaden workflow triggers and add merge_group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two main changes: it updates the workflow triggers in the GitHub Actions configuration and simplifies the implementation of the
SupervisorPolicyenum in Rust by leveraging theDefaultderive macro. These changes help streamline CI/CD processes and reduce boilerplate code.